一杯水 is right, means a cup of water;
一杯子水 is not right.
杯: quantifier. you can say 一杯/两杯/几杯。
杯子:noun, such as cup, glass. This 杯子 is pretty. where is my 杯子?
But, in some areas,especially the north of China, 杯=杯子,means cup/glass, for example, where is my 杯/杯子? this is my 杯/杯子。I want to buy a 杯/杯子。