A "citizen" legally belongs to a nation, and is entitled to protections and privileges such as the right to vote.
A "civilian" is someone who is not in the armed forces.
In the United States, almost all people serving in the armed forces are citizens. They are citizens before they join the armed forces, they remain citizens while they are in the armed forces, and they continue to be citizens when they leave the armed forces.
They are civilians before they join the armed forces. They are members of the military while they are in the armed forces. They become civilians again when they leave the armed forces.